Fix for sending delivery and zip4 verification in the same request #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
att14
reviewed
Apr 9, 2018
easypost/__init__.py
Outdated
| for param in verify_strict: | ||
| url += "verify_strict[]={0}".format(param) | ||
| url += '?' + '&'.join( | ||
| ['verify[]=' + param for param in verify] + |
…t-python into zip4-delivery-fix-abram
Contributor
Author
|
@att14 how's this? |
att14
reviewed
Apr 11, 2018
easypost/__init__.py
Outdated
|
|
||
| @classmethod | ||
| def create(cls, api_key=None, verify=None, verify_strict=None, **params): | ||
| def create(cls, api_key=None, verify=[], verify_strict=[], **params): |
Contributor
There was a problem hiding this comment.
You can't use mutable types as kwargs.
Contributor
Author
There was a problem hiding this comment.
I suppose this could be called repeatedly. Uhg I'm not a fan of that bit of Python behavior
att14
approved these changes
Apr 12, 2018
mwaldt
approved these changes
Apr 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old code constructed broken query params